On Fri, Feb 27, 2026 at 03:14:38PM -0700, Simon Glass wrote: > Hi Tom, > > On Wed, 25 Feb 2026 at 10:12, Tom Rini <[email protected]> wrote: > > > > On Wed, Feb 25, 2026 at 09:23:49AM -0700, Simon Glass wrote: > > > > > From: Simon Glass <[email protected]> > > > > > > Provide a way to create disk images which consist of multiple filesystem > > > images. > > > > > > Provide an option to use the current directory for images, instead of > > > persistent-data directory. This makes it easy for C tests to locate the > > > image. > > > > > > Signed-off-by: Simon Glass <[email protected]> > > > --- > > > > > > test/py/tests/fs_helper.py | 97 ++++++++++++++++++++++++++++++++++++++ > > > 1 file changed, 97 insertions(+) > > > > It seems wrong to ignore the existing function to create disk images. > > Can we do this in steps? I have a pending series to rework the test > images (and move them to the persistent dir) but it is at least 10 > patches, so I figured I should start with this.
Yes, as doing this in steps you should convert the existing disk image part to be available too via the class and not construct a new one. And I want to say that given what you said on the call about more generic imagre creation I'm wary about this "cleanup" leading to something odd being built on top of it. -- Tom
signature.asc
Description: PGP signature
