On 15/12/2011 17:34, Fabio Estevam wrote:
> Let imx_get_mac_from_fuse function be a common function, so that other
> mx28 boards can reuse it.
>
> Signed-off-by: Fabio Estevam <fabio.este...@freescale.com>
> ---
Hi Fabio,
> + if (mx28_wait_mask_clr(&ocotp_regs->hw_ocotp_ctrl_reg, OCOTP_CTRL_BUSY,
> + MXS_OCOTP_MAX_TIMEOUT)) {
> + puts("MXS FEC: Can't get MAC from OCOTP\n");
> + return;
> + }
> +
> + data = readl(&ocotp_regs->hw_ocotp_cust0);
> +
> + mac[0] = 0x00;
> + mac[1] = 0x04;
Maybe it is worth to add a comment to explain that the magic numbers
0x00 - 0x04 are the Freescale's vendor prefix.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de
=====================================================================
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
