Hi Stephen, On Mon, Apr 9, 2012 at 2:36 PM, Stephen Warren <swar...@wwwdotorg.org> wrote: > On 04/02/2012 05:18 PM, Simon Glass wrote: >> From: Yen Lin <ye...@nvidia.com> >> >> Add code to set up the warm boot area in the Tegra CPU ready for a >> resume after suspend. >> >> Signed-off-by: Simon Glass <s...@chromium.org> >> Acked-by: Stephen Warren <swar...@nvidia.com> > >> +static enum fuse_operating_mode fuse_get_operation_mode(void) >> +{ >> + u32 chip_id; >> + struct apb_misc_gp_ctlr *gp = >> + (struct apb_misc_gp_ctlr *)TEGRA2_APB_MISC_GP_BASE; >> + >> + chip_id = (readl(&gp->hidrev) & HIDREV_CHIPID_MASK) >> >> + HIDREV_CHIPID_SHIFT; > > This duplicates code from the SKU retrieval function added in an earlier > patch. Not a big deal; it could be unified in a followon patch.
Yes, I didn't notice that - yes we can tidy it up later. Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot