-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 10/05/12 06:15, Stefan Roese wrote: > On 10/04/2012 07:14 PM, Scott Wood wrote: >> On 10/04/2012 02:36:34 AM, Stefan Roese wrote: >>> On 10/02/2012 10:08 PM, Scott Wood wrote: >>>>>>> +void __noreturn jump_to_image_linux(void *arg) +{ + >>>>>>> debug("Entering kernel arg pointer: 0x%p\n", arg); + >>>>>>> typedef void (*image_entry_arg_t)(void *, ulong r4, >>> ulong r5, >>>>>>> ulong r6, + ulong r7, ulong r8, >>> ulong r9) >>>>>>> + __attribute__ ((noreturn)); + image_entry_arg_t >>>>>>> image_entry = + >>>>>>> (image_entry_arg_t)spl_image.entry_point; + + >>>>>>> image_entry(arg, 0, 0, EPAPR_MAGIC, >>> CONFIG_SYS_BOOTMAPSZ, 0, 0); >>>>>>> +} >>>>>> >>>>>> At what point does the image get cache-flushed? >>>>> >>>>> Not at all right now. MPC5200 has dcache disabled, at least >>>>> in the SPL. Other PowerPC architectures might add a cache >>>>> flush here if needed >>> at >>>>> some time. Okay? >>>> >>>> Or they might forget to do so and have weird bugs. >>>> >>>> Why not just call flush_cache() on the image now? Non-SPL >>>> does >>> this in >>>> common code, not even PPC-specific. >>> >>> Okay, probably better to add this code now. But shouldn't we >>> add this code to the common SPL framework code then? Right >>> before calling jump_to_image_linux()? >> >> Sure, I didn't mean it should go here (it needs to be somewhere >> that knows the image start/end, not just the entry point). This >> is just the patch that prompted me to ask the question. > > I see. > > Tom, whats your input on this? Do you see any problems about > putting a flush_cache() into the common SPL framework code? Are any > of the ARM platforms currently using this framework already running > with d-cache enabled?
On ARM, jump_to_image_linux() calls cleanup_before_linux() to take care of flushing, etc. So the PowerPC jump_to_image_linux should take care of what it needs to take care of. - -- Tom -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQIcBAEBAgAGBQJQbvs/AAoJENk4IS6UOR1WXB4P/0g4rlsgzs1QBqRnM7oo/gDx k3yNcN4jz7eHkY+X0hdgd8IqH8znqvptbr6D0w7/a35ZNqe0YZGqjQVI6DOh6QPx oVSDYuywbP9arA83sYy44Ucf/acn/vYuvFqHoM7PTukUGcX3pdG5V4qiGnHe0H/B 4cp0iyY9wvt/eSrB6P7ZB2rse+fnQswBVEQ20Lkinr2ZkXcQMxiUHixfmxtQSV+b SSHnd1XjSeIrLGHw4HlyoDYjZ8DQc4Zw/Sc/9fGnuwOiir4K743VXhU5hao4fQWp F8OQgLaVkxxkALkwfdYS1G+vUgfzCxvWTxG3x/9oXUPh8VcXkqwhK3CXcnvLGAs8 3gu33UFzgMAFfd5bthwgKx50K9dTVSUWRsOu3lDUDi3jYZNoRpxcatQ5dWV1IW2V UGgBQ4e7UE0h3SvQocnHbJAm+qcLyT6USH2xTyWRqi129OwKbuYM4nDH/nrYW11I K7VY+tCqP9hoReuzVzFzsfBdaAzS9A+Z3uejYzfKaolnFvp8Bz4HVLdDQ9XBnddv 3flO7M4cO35xroBQ2QltibUkI5tgp3lmsVBuMUj5CQ7uojdjHoUNjfRKAKkKJYVp 07vlraRqNiqO1w7WoJCb3rLyH5P/9gZYoMkRsmtjA/Upg4FV+ntQgzDINANGE7e9 Lqd5K3EBnDLeLXt1bdWY =5wlk -----END PGP SIGNATURE----- _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot