Hi Simon, Jan, On Wed, Oct 21, 2026 at 09:43, Jan Kehren <[email protected]> wrote:
> Hi Simon, > > Thanks for the review. > >> As written, a board maintainer can't act on this. > > Igor's "optee: do not announce RPMB from within a supplicant RPC" should > fix this. It is still at v3 on the list, so there is no commit to point > at yet. I would like to send a follow-up once it lands, naming it and > adding the "mmc dev" hint you suggest. > >> A follow-up could guard the mmc path with IS_ENABLED(CONFIG_MMC) and >> drop the dependency. > > Good point, and happy to take that on too: avb_init_mmc() calls > find_mmc_device() unconditionally, so it needs the guards plus a broader > build check. > > With both heading for follow-ups I would rather not respin, if that sounds > reasonable. The series has Reviewed-by throughout and Igor is rebasing on > top, so a v4 would mostly cost him time. Mattijs, if you are happy with > that, v3 should be ready to go and I can provide a follow-up afterwards. I like Simon's suggestions but I'm happy with taking v3 and taking follow-up patches. Thanks for the great work everyone Mattijs. > > (It did reach patchwork as 2322465, not sure why it didn't show up in > the first place) > > Thanks, > Jan
