On 2026-10-17 13:42, Marek Vasut wrote: > On 9/16/26 2:38 PM, Anders Roxell wrote: > > Adapt the DWC3 core files to U-Boot: core, io, Makefile and the omap and > > ti phy glue. > > > > core.c is a big diff because the kernel file is trimmed to what U-Boot > > builds. The main changes: rename struct device to udevice, use > > generic_phy_init() instead of phy_init(), and drop the host-only and DRD > > paths U-Boot does not use. > > > > U-Boot gets the dwc3 clocks in the glue driver through the DM clock > > framework, not in the core. So dwc3_clk_enable() is dropped. We kept > > dwc3_clk_disable() in dwc3_core_exit(), but the core never gets these > > clocks, so it does nothing. It can go in a follow-up. > > > > Keep the U-Boot Makefile instead of the kernel one. The kernel Makefile > > lists glue drivers and core files that we do not import, like dwc3-qcom, > > dwc3-pci, host.c, drd.c and ulpi.c. The source files are not there and > > the CONFIG symbols do not exist in our Kconfig, so those lines are dead > > text. Only keep the entries we can build. > > > > Co-developed-by: Jerome Forissier <[email protected]> > > Signed-off-by: Jerome Forissier <[email protected]> > > Co-developed-by: Jens Wiklander <[email protected]> > > Signed-off-by: Jens Wiklander <[email protected]> > > Signed-off-by: Anders Roxell <[email protected]> > > --- > > drivers/usb/dwc3/Makefile | 17 +- > > drivers/usb/dwc3/core.c | 1761 ++++++++------------------------- > How do you think I can review this ?
Fair point. In v10 it is four patches: - remove the code U-Boot does not use - bring back the U-Boot entry points - adapt to the U-Boot APIs - fix up io.h, the Makefile and the TI glue Cheers, Anders
