On 2026-10-17 13:36, Marek Vasut wrote:
> On 9/16/26 2:38 PM, Anders Roxell wrote:
>
> [...]
>
> > diff --git a/include/linux/compat.h b/include/linux/compat.h
> > index d4ba4d0088a0..16c02260c111 100644
> > --- a/include/linux/compat.h
>
> [...]> +/* From include/linux/reset.h */
> > +
> > +struct reset_control;
> > +
> > +static inline int reset_control_assert(struct reset_control *rstc)
> > +{
>
> Should this call reset_assert() ?
>
> See e.g. this, which should also be updated:
>
> drivers/phy/cadence/phy-cadence-sierra.c:#define reset_control_assert(rst)
> cdns_reset_assert(rst)
> drivers/phy/cadence/phy-cadence-sierra.c: reset_control_assert(sp->phy_rst);
> drivers/phy/cadence/phy-cadence-sierra.c: reset_control_assert(sp->phy_rst);
> drivers/phy/cadence/phy-cadence-sierra.c:
> reset_control_assert(phy->phy_rst);
>
> > + return 0;
> > +}
> > +
> > +static inline int reset_control_deassert(struct reset_control *rstc)
> > +{
>
> Should this call reset_deassert() ?
Yes. In v10 both helpers are in include/reset.h and call reset_assert()
and reset_deassert(). NULL returns 0 like in Linux, and dwc3 needs that.
A new patch moves sierra and torrent to these helpers, with your
Suggested-by. Only build tested.
Cheers,
Anders
