On 10/29/26 18:34, Maxin B. John wrote:
Turn on CMD_BINOP for sandbox and sandbox64 so the binop tests are
built and run in CI on both 32-bit and 64-bit builds.
Signed-off-by: Maxin B. John <[email protected]>
Which tests? I could not find any depending on CONFIG_CMD_BINOP.
HTML documentation for the command does not exist.
The online documentation leaves the user clueless:
Usage:
binop op count [*]src1 [*]src2 [[*]dest]
- compute binary operation of data at/in src1 and
src2 (either *memaddr, env var name or hex string)
and store result in/at dest, where op is one of
xor, or, and.
What is count good for?
What should a variable contain?
Can we simply eliminate the command? It is only used by a single board.
When I see comments like these in the code I am inclined to remove the
board completely:
drivers/sysinfo/sysinfo-uclass.c:21:
* There is some very dodgy error handling in gazerbeam,
Best regards
Heinrich
---
configs/sandbox64_defconfig | 1 +
configs/sandbox_defconfig | 1 +
2 files changed, 2 insertions(+)
diff --git a/configs/sandbox64_defconfig b/configs/sandbox64_defconfig
index f861d3ef06db..c4ad63ce63be 100644
--- a/configs/sandbox64_defconfig
+++ b/configs/sandbox64_defconfig
@@ -43,6 +43,7 @@ CONFIG_CMD_NVEDIT_EFI=y
CONFIG_CMD_NVEDIT_INFO=y
CONFIG_CMD_NVEDIT_LOAD=y
CONFIG_CMD_NVEDIT_SELECT=y
+CONFIG_CMD_BINOP=y
CONFIG_LOOPW=y
CONFIG_CMD_MD5SUM=y
CONFIG_CMD_MX_CYCLIC=y
diff --git a/configs/sandbox_defconfig b/configs/sandbox_defconfig
index a3fa52460827..c63a4df8befa 100644
--- a/configs/sandbox_defconfig
+++ b/configs/sandbox_defconfig
@@ -74,6 +74,7 @@ CONFIG_CMD_NVEDIT_EFI=y
CONFIG_CMD_NVEDIT_INFO=y
CONFIG_CMD_NVEDIT_LOAD=y
CONFIG_CMD_NVEDIT_SELECT=y
+CONFIG_CMD_BINOP=y
CONFIG_LOOPW=y
CONFIG_CMD_MD5SUM=y
CONFIG_CMD_MEM_SEARCH=y
