On Fri, Oct 30, 2026 at 08:25:32PM +0200, Maxin John wrote: > Hi Tom, > > On Fri, Oct 30, 2026 at 6:39 PM Tom Rini <[email protected]> wrote: > > > > On Fri, Oct 30, 2026 at 05:58:58PM +0200, Maxin John wrote: > > > Hi Heinrich, > > > > > > On Fri, Oct 30, 2026 at 1:26 AM Heinrich Schuchardt <[email protected]> > > > wrote: > > > > > > > > On 10/29/26 18:34, Maxin B. John wrote: > > > > > Turn on CMD_BINOP for sandbox and sandbox64 so the binop tests are > > > > > built and run in CI on both 32-bit and 64-bit builds. > > > > > > > > > > Signed-off-by: Maxin B. John <[email protected]> > > > > > > > > Which tests? I could not find any depending on CONFIG_CMD_BINOP. > > > > > > This change is a follow-up to my recently submitted binop clean-up patch: > > > https://lists.u-boot-project.org/pipermail/u-boot/2026-October/637804.html > > > > > > Following the review comments on that patch, I have also submitted tests > > > to > > > improve binop test coverage: > > > https://lists.u-boot-project.org/pipermail/u-boot/2026-October/637974.html > > > > > > These tests depend on CONFIG_CMD_BINOP, which is why I enabled it in > > > sandbox and sandbox64. > > > > > > > HTML documentation for the command does not exist. > > > > The online documentation leaves the user clueless: > > > > > > Agreed. The documentation for binop is insufficient and could be improved. > > > > > > > Usage: > > > > binop op count [*]src1 [*]src2 [[*]dest] > > > > - compute binary operation of data at/in src1 and > > > > src2 (either *memaddr, env var name or hex string) > > > > and store result in/at dest, where op is one of > > > > xor, or, and. > > > > > > > > What is count good for? > > > > What should a variable contain? > > > > > > > > Can we simply eliminate the command? It is only used by a single board. > > > > > > I am not aware of any other users of this command apart from the > > > gazerbeam board. > > > Personally, I can work around its removal if that is what the > > > maintainers decide. > > > > Perhaps what's missing here is what your motivation is for this cleanup? > > My primary motivation for the cleanup was to address existing safety issues > and make the command more robust, specifically fixing corner cases such as > heap > corruption and crashes caused by over-sized input. > > I originally enabled binop while experimenting with U-Boot on the Milk-V Duo. > There, I was exploring ways to manipulate binary configuration data using > binop. > > I agree that the command has limited usage today, and that similar > functionality > can often be achieved using other U-Boot commands. I don't have a strong > preference either way and am happy to go with whatever the maintainers > feel is best.
Thanks for explaining. Yes, if you don't mind, please do finish cleaning up the command and adding a documentation page for it as well. -- Tom
signature.asc
Description: PGP signature
