Hopefully it shouldn't break anything. If we comment out all the palette restore loops, you don't get a nice palette restored when you switch back to the console. Its all grey- scale. By selectively choosing to just re-program the pipeline in the chip which is enabled, you get the correct palette for the console.
Strictly speaking, we're now not restoring the full set of the video chips registers, so perhaps if your bios knows how to re-program the chip and say connect an external monitor to the other pipe, we'll have left it with a bad palette. IMO, thats better than the crashes, and perhaps something Intel will sort out "properly". I didn't want to delve into how complex it might be to deliberately program both pipelines just for the sake of restoring their palette regs. The "correct"? fix might be to save the palette regs when the crtc pipleine is first used by the X11 driver, then re-program it before we shut it off. That way, only palettes which have been touched are re- programmed. -- laptop hangs when switching video mode https://bugs.launchpad.net/bugs/127101 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
