tools/virsh-snapshot.c 
  -> cmdSnapshotCreate collects arguments and sets flags
  -> virshSnapshotCreate does the handling then
     - gets the xml in const char *from
     - flags in unsigned int flags
  -> virDomainSnapshotCreateXML gets xml and flags
  -> impl callback conn->driver->domainSnapshotCreateXML(domain, xmlDesc, 
flags);
     from src/qemu/qemu_driver.c that is qemuDomainSnapshotCreateXML
  -> virDomainSnapshotRedefinePrep
  -> virDomainDefCheckABIStability <- here the breakage starts complaining 
about the mismatch

IMHO we could add a --force flag that says "ignore ABI checks at your own risk".
This would end up as a new flag which still is available in 
virDomainSnapshotRedefinePrep.
And that could then ignore the retval or not call virDomainDefCheckABIStability 
at all.

Flag namespace would be like VIR_DOMAIN_SNAPSHOT_CREATE_DISK_ONLY and siblings
Probably need to update virCheckFlags in qemuDomainSnapshotCreateXML

Let me try to code up something for that and build a PPA to test ...

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1802944

Title:
  error: unsupported configuration: Target domain machine type

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1802944/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to