On Sat, 21 May 2011 18:52:20 +0100, Max Bowsher <m...@f2s.com> wrote: > A huge amount of the UDD importer's interesting code is in one file, > icommon.py. > > I'd like to submit a series of changes to break it up such that only the > most common bits of code remain there.
Good idea. > Things I'm thinking of: > > 1) Move code in icommon.py that is uniquely invoked by a single > executable component of the importer out to that component: I think I would prefer it if they moved to their own modules... > e.g. > class ImportList, class PackageToImport --> import_package.py > > class SubprocessMonitor, class ThreadDriver --> mass_import.py Especially things like this. I don't have a strong preference though. Thanks, James -- ubuntu-distributed-devel mailing list ubuntu-distributed-devel@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-distributed-devel