On Thursday 11 December 2008 16:51, Bernhard Reutner-Fischer wrote: > On Thu, Dec 11, 2008 at 02:17:53AM +0100, Denys Vlasenko wrote: > >On Tuesday 09 December 2008 22:00, Rob Landley wrote: > >> Right now, there are still two "old" linuxthreads branches in uClibc, and > >> as > >> far as I can tell we'll be supporting them in perpetuity. (For a > >> definition > >> of "support" that involves leaving them alone unless somebody complains.) > > > >We need to stop doing that, though. > > > >We have "ond" and "new" vfprintf, "old" and "new" regex, > >"old" and "new" threads, "old" and "new" fnmatch. > > > >Let's just decide on something, and disable things which are > >really "old". Because currently, I need telepathic powers > >to figure out which regex to choose: > > > >Sometimes "old" is actually old and better be dropped, > >other times "old" is actually "stable and recommended", > >and "new" is "work in progress, and maybe developer was hit > >by the bus, nobody knows". For one, I do not know > >what vfprintf or regex to choose, I use rand(). > > > >But users are even less likely than we to know what to choose. > >We, as developers, need to help them. > > > >It's not like disabling or even rm'ing one or the other > >is irreversible. It all will still be in a history. > > > >Just IMHO. Bernhard, I guess it's up to you to decide this. > > Let's leave the complete libpthread/* out of this particular discussion > for now. > > As for the rest, i currently don't have a strong opinion on which > of the old or new variants to keep, which malloc impl (of the 3) to > drop. I'm open to suggestions. > > Any preferences / thoughts?
UCLIBC_HAS_REGEX=y # UCLIBC_HAS_REGEX_OLD is not set # cd test/regex # ./tst-regex2 test 0 pattern 0 regexec without REG_NOSUB did not find the correct match # ./tst-regex2.glibc test 0 pattern 0 test 0 pattern 1 test 0 pattern 2 test 1 pattern 0 test 1 pattern 1 test 1 pattern 2 test 2 pattern 0 test 2 pattern 1 test 2 pattern 2 test 3 pattern 0 test 3 pattern 1 With UCLIBC_HAS_REGEX=y UCLIBC_HAS_REGEX_OLD is not set # ./tst-regex2 test 0 pattern 0 test 0 pattern 1 test 0 pattern 2 test 1 pattern 0 test 1 pattern 1 test 1 pattern 2 test 2 pattern 0 incorrect num_regs 30 So, none of them pass our testsuite. :( :( And "make compile" in test/ neither tests for existence of ../install_dir which is crucial for compile, nor tracks dependencies... <sigh> -- vda _______________________________________________ uClibc mailing list uClibc@uclibc.org http://busybox.net/cgi-bin/mailman/listinfo/uclibc
