Hi Emily > For those interested I've pushed the latest updates to my legend branch: > > https://github.com/egouge/udig-platform/tree/legend
were you thinking to open a pull request for that? Or are you still working on it? Thank you! Andrea > > > > > > On 10/4/2012 9:07 AM, andrea antonello wrote: >> >> Hi Emily, >> I am currently abroad so I can only look at your image. >> >>> I've played around a bit more with the legend, in particular the ramp >>> option. See attached image - does that better meet your requirements? >>> >>> Keep in mind I have not done anything with the NO_DATA values yet. >> >> >> Wooo, I really like that! It looks like the proper raster ramp legend. >> >> Thanks, >> Andrea >> >> >>> >>> Emily >>> >>> >>> On 9/21/2012 5:25 AM, andrea antonello wrote: >>>> >>>> >>>> Hi Emily, very nice work, always good to see you active! >>>> >>>> Comments: >>>> >>>> 1) ramps >>>> I am not able to review right now, but I would love to see the legend >>>> ramp enhanced, since that one is not really helpful. >>>> >>>> The ramp should be vertical and pass through at least a couple of >>>> colors, which means it also should take up the space of about 5 boxes >>>> usually taken up by the vectore box. >>>> >>>> I have done that kind of work for the JGrass raster legend and would >>>> be happy to retire that one to have it all inside the legend. >>>> Do you think we could somehow converge on that? >>>> >>>> Also, what defines when to use a category or a ramp? >>>> >>>> 2) In the above screen I see that some values seem to be integers, >>>> whereas others doubles. Why is that happening? >>>> >>>> 3) I would suggest to consider novalues. I don't think that someone >>>> wants to have the -9999.0 in the legend? Maybe that could even be put >>>> inside a preference panel to set? >>>> >>>> 4) I would suggest to put borders around the boxes in order to enhance >>>> readability. In the case a color is the same as the background, it >>>> looks odd (ex the -9999.0, but also white of the ramp on white >>>> background) >>>> >>>> Cheers, >>>> Andrea >>>> >>>> >>>> >>>> On Thu, Sep 20, 2012 at 10:01 PM, Emily Gouge <[email protected]> >>>> wrote: >>>>> >>>>> >>>>> For the project I'm working on I needed to add the ability to include >>>>> themed >>>>> rasters in the legend. In the process of adding this functionality >>>>> I've >>>>> made a number of improvements to the udig legend. >>>>> >>>>> Updates include: >>>>> 1) Fixed the legend style configurator so it remembers the style >>>>> parameters >>>>> entered by the user. Previously, it was always displaying the default >>>>> values. >>>>> >>>>> 2) I added some layer interceptors to track when legend layers are >>>>> added/removed and add listeners. I did this so I would watch context >>>>> changes and updated the legend when another layer changed. I updated >>>>> the >>>>> legend if the style changed, visibility changed, or the context model >>>>> changes. This means the user does not have to refresh the map to >>>>> update >>>>> the >>>>> legend if they change a layer. >>>>> >>>>> 3) Fixed some rendering issues with the height of the legend being >>>>> bigger >>>>> than required. >>>>> >>>>> 4) I added code to display ColorMap values for GridCoverage whose >>>>> styles >>>>> include a ColorMap (see attached image for example). If the style does >>>>> not >>>>> include a ColorMap then the default icon is used. I supported the >>>>> three >>>>> types of ColorMap: intervals, values and ramp. >>>>> >>>>> I've made a pull request: >>>>> https://github.com/uDig/udig-platform/pull/149 >>>>> >>>>> Feedback/comments are welcome. >>>>> >>>>> Emily >>>>> >>>>> _______________________________________________ >>>>> User-friendly Desktop Internet GIS (uDig) >>>>> http://udig.refractions.net >>>>> http://lists.refractions.net/mailman/listinfo/udig-devel >>>>> >>>> _______________________________________________ >>>> User-friendly Desktop Internet GIS (uDig) >>>> http://udig.refractions.net >>>> http://lists.refractions.net/mailman/listinfo/udig-devel >>>> >>> >> _______________________________________________ >> User-friendly Desktop Internet GIS (uDig) >> http://udig.refractions.net >> http://lists.refractions.net/mailman/listinfo/udig-devel >> > _______________________________________________ > User-friendly Desktop Internet GIS (uDig) > http://udig.refractions.net > http://lists.refractions.net/mailman/listinfo/udig-devel _______________________________________________ User-friendly Desktop Internet GIS (uDig) http://udig.refractions.net http://lists.refractions.net/mailman/listinfo/udig-devel
