[UFRaw-Devel] latest CVS broke rotation/flip logic

[Frank van Maarseveen]

Try this sequence:

-       rotate 10.0 degrees
-       <=> flip (notice that the angle shows 170 but it should be -10)
-       change the number 170 into 171 and notice that the image is almost
        turned upside down.

The patch below restores the original behavior but the question is of
course what the bug was it tried to fix.


diff --git a/ufraw_preview.c b/ufraw_preview.c
index 4710628..7166672 100644
--- a/ufraw_preview.c
+++ b/ufraw_preview.c
@@ -2205,14 +2205,9 @@ static void flip_image(GtkWidget *widget, int flip)
            data->unnormalized_angle -= 90;
            break;
        case 1:
-           data->unnormalized_angle = 180-data->unnormalized_angle;
-           if ( (data->reference_orientation&4) == 4)
-               data->unnormalized_angle += 180;
-           break;
        case 2:
+           data->reference_orientation ^= flip;
            data->unnormalized_angle = -data->unnormalized_angle;
-           if ( (data->reference_orientation&4) == 4)
-               data->unnormalized_angle += 180;
            break;
        default:
            g_error("flip_image(): flip:%d invalid", flip);

-- 
Frank

------------------------------------------------------------------------------
Come build with us! The BlackBerry&reg; Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9&#45;12, 2009. Register now&#33;
http://p.sf.net/sfu/devconf
_______________________________________________
ufraw-devel mailing list
ufraw-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ufraw-devel