On Fri, Oct 02, 2009 at 10:52:57AM -0500, Udi Fuchs wrote:
> The flip logic still doesn't work. If you do a horizontal flip and
> then a vertical flip the result is equivalent to a 180 rotation, yet
> the rotation angle stays at 0.
An even flip count happens to be equivalent to a rotation. But this
is not easy to rectify unless the angle is always denormalized using
orientation bits. But then the angle reset value would no longer be zero.
>
> Also, it is not clear to what state the reset button sets you. I think
> that reset should return us to the original camera orientation.
Not possible since <Orientation>%d</Orientation> gets overwritten
by the rotation done by ufraw: there is no <CameraOrientation> element
and rotation angle is always normalized to 0..90 degrees.
>
> Lastly, I think that if the camera orientation is not 0, then it
> should show up in the rotation adjustment.
Similar to the first point.
Right now when the user doesn't flip the image then the reset button
will always reset the image orientation and angle to what it was at the
start. The current rotation/orientation interaction is not bad but there
is room for improvement:
- flip_image() appears to lack a call to make the reset sensitive again.
- reset after 90+1 degree rotate doesn't handle the cropping area
gracefully:
set_rotation_angle() should rotate crop area using flip_image for the
larger part (the 90 degree multiple). Or for simplicity just always
reset the crop area if it was at reset position before.
--
Frank
------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
ufraw-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ufraw-devel
