I think I got all the rotation code in order now.
There is a small part that I don't like:
int ufraw_flip_image(ufraw_data *uf, int flip)
{
ufraw_flip_orientation(uf, flip);
if (flip==1 || flip==2 || flip==4 || flip==7) {
uf->conf->rotationAngle = -uf->conf->rotationAngle;
ufraw_normalize_rotation(uf);
}
This code seems to belong in the normalize/unnormalize functions, but
I don't see how.
> - reset after 90+1 degree rotate doesn't handle the cropping area
> gracefully:
> set_rotation_angle() should rotate crop area using flip_image for the
> larger part (the 90 degree multiple). Or for simplicity just always
> reset the crop area if it was at reset position before.
I agree. This should be the case when aspect ratio is not locked.
I think that if aspect ration we should flip to 1/aspect ratio once a
45 angle is crossed.
Udi
------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
ufraw-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ufraw-devel
