Alexander Gurov wrote:
I've applied the patch and placed few comments marked as "NOTE" into source
code. Could you please check the code which these notes are related to?
(these comments relates extension point functions arguments)
One thing I wasn't been able to cleanup is the repository browser,
which is currently look odd, especially when there is multiple SVN
repositories registered in SVN Repositories view. You can see this
oddity on your own screenshot at
http://docs.codehaus.org/download/attachments/79298641/browse_repo.PNG
BTW, thank you for updating the wiki page. You may also want to put
update site url up there...
Also could you please specify if I can remove the code which is not used now
or you have some ideas about future improvements of M2Eclipse SCM extension
point that may require the code I told about?
I think you can remove CheckoutAsMavenProjectAction,
CheckoutAsMavenProjectPage and CheckoutAsMavenProjectWizard classes that
been generalized in generic checkout wizard.
// NOTE initially revision number is empty. Is it correct behaviour or not?
It is certainly not a valid tag/revision (usually it happens when user
selected "check out head revision" on checkout wizard page), so history
browser should allow to be used if initial revision is empty, but
verification should say that it is an invalid revision/tag. I was
thinking that maybe ScmHandlerUi.isValid*() methods should return
IStatus instead of boolean but then decided on simplicity. What do you
think?
//NOTE if user writes the URL by hands it does not start with
SVNScmHandler.SVN_SCM_ID substring. Is it correct behaviour or not?
Good catch. ScmUrl should have "scm:svn:" prefix set automatically. I
will fix this in the wizard for 0.9.3 and I also will have to pass null
if there is no url selected, so you'll need to add a null check (I will
put a dummy SvnUrl for now, until it is fixed on your side). Sorry about
this.
Also, I noticed that in org.eclipse.core.runtime.adapters extension
point you can use IResourceTreeNode as a class to adapt to. Though I am
not sure if it is a good idea to allow to checkout from the repository
root, given that in most cases you'll have many projects +
trunk/tags/branches structure and it is unlikely that anyone would want
to import them all at the same time into Eclipse workspace. In this
regard, the following screenshot on the wiki doesn't show great
practice, perhaps it is better if it would show selection of the "trunk"
folder
http://docs.codehaus.org/download/attachments/79298641/co_as_maven.PNG
Thanks
Eugene
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
