> One thing I wasn't been able to cleanup is the repository browser, >which is currently look odd, especially when there is multiple SVN >repositories registered in SVN Repositories view. You can see this >oddity on your own screenshot at >http://docs.codehaus.org/download/attachments/79298641/browse_repo.PNG
So what is odd on a screenshot? I simply can't understand, shame on me. :) > BTW, thank you for updating the wiki page. You may also want to put >update site url up there... > I think you can remove CheckoutAsMavenProjectAction, >CheckoutAsMavenProjectPage and CheckoutAsMavenProjectWizard classes that >been generalized in generic checkout wizard. Done. > It is certainly not a valid tag/revision (usually it happens when user >selected "check out head revision" on checkout wizard page), so history >browser should allow to be used if initial revision is empty, but >verification should say that it is an invalid revision/tag. I was >thinking that maybe ScmHandlerUi.isValid*() methods should return >IStatus instead of boolean but then decided on simplicity. What do you >think? Good idea. I think the same relates to isValidUrl() method. Usage of IStatus instead of boolean should allows to improve validation messages, which could be passed in that case from validation code to wizard UI through IStatus object. So, we can make this part of UI more tolerant to users. > Good catch. ScmUrl should have "scm:svn:" prefix set automatically. I >will fix this in the wizard for 0.9.3 and I also will have to pass null >if there is no url selected, so you'll need to add a null check (I will >put a dummy SvnUrl for now, until it is fixed on your side). Sorry about >this. Done. > Also, I noticed that in org.eclipse.core.runtime.adapters extension >point you can use IResourceTreeNode as a class to adapt to. Though I am >not sure if it is a good idea to allow to checkout from the repository >root, given that in most cases you'll have many projects + >trunk/tags/branches structure and it is unlikely that anyone would want >to import them all at the same time into Eclipse workspace. It is easy to change declaration in plugin.xml back, but what about situations when repository location root points to project itself, not to recommended project structure? >In this regard, the following screenshot on the wiki doesn't show great >practice, perhaps it is better if it would show selection of the "trunk" >folder > http://docs.codehaus.org/download/attachments/79298641/co_as_maven.PNG Fixed. -- View this message in context: http://www.nabble.com/m2eclipse-and-subversive-tp16045807s177p16763406.html Sent from the Maven Eclipse - User mailing list archive at Nabble.com. --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
