Alexander Gurov wrote:
One thing I wasn't been able to cleanup is the repository browser,
which is currently look odd, especially when there is multiple SVN
repositories registered in SVN Repositories view. You can see this
oddity on your own screenshot at
http://docs.codehaus.org/download/attachments/79298641/browse_repo.PNG
So what is odd on a screenshot? I simply can't understand, shame on me. :)
Actually it is not just a screenshot. The url selection dialog is not
quite right.
Here is how it look like when url field is empty:
So, I selected "trunk", hit ok, and then hit "Browse" on wizard page
again. The dialog I get after that don't show all repositories, so you
can't select anything outside of that repository and have to manually
clean url field in order to get back to the full list. That doesn't seem
right:
It is certainly not a valid tag/revision (usually it happens when user
selected "check out head revision" on checkout wizard page), so history
browser should allow to be used if initial revision is empty, but
verification should say that it is an invalid revision/tag. I was
thinking that maybe ScmHandlerUi.isValid*() methods should return
IStatus instead of boolean but then decided on simplicity. What do you
think?
Good idea. I think the same relates to isValidUrl() method. Usage of IStatus
instead of boolean should allows to improve validation messages, which could
be passed in that case from validation code to wizard UI through IStatus
object. So, we can make this part of UI more tolerant to users.
I'll update API and will send you another patch for that. You may have
to update it with your verification details...
Also, I noticed that in org.eclipse.core.runtime.adapters extension
point you can use IResourceTreeNode as a class to adapt to. Though I am
not sure if it is a good idea to allow to checkout from the repository
root, given that in most cases you'll have many projects +
trunk/tags/branches structure and it is unlikely that anyone would want
to import them all at the same time into Eclipse workspace.
It is easy to change declaration in plugin.xml back, but what about
situations when repository location root points to project itself, not to
recommended project structure?
Maybe you can detect if repo has trunk and other folders and don't
adapt repo if it does (e.g. return null from adapter factory).
In this regard, the following screenshot on the wiki doesn't show great
practice, perhaps it is better if it would show selection of the "trunk"
folder
http://docs.codehaus.org/download/attachments/79298641/co_as_maven.PNG
Fixed.
Thanks. I've cleaned page a bit.
BTW, there is similar issue with the wizard screenshot. Sorry for such
attention to tiny details. :)
http://docs.codehaus.org/download/attachments/79298641/co_options.PNG
regards,
Eugene
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
