Anne,
> So it is worth me making some effort to make my code good enough to be
> integrated.
I'm sure your codes will be good enough to be integrated; good codes make bug-catching easier, so
that's a powerful incentive.
As you mentioned in another post, you're finding [integrating your codes with OFBiz's] not as easy
as you hoped (especially shipping inc tax).
I did start out trying to retain as much of OFBiz codes (in some areas like invoicing and taxes)
as possible. But I find myself writing a whole new chunk parallel to existing OFBiz codes, rather
than neatly splicing in enhancements. Well, at least my new chunks use almost exactly the same
coding style and methodologies as existing codes, so that's "in line with OFBiz".
The problem is that many codes in OFBiz are themselves "parallel chunks of repeated codes". Hard
to splice in enhancements in a central location; only possibly to riddle the enhancements into
existing codes.
Is "parallel chunks of repeated codes" wrong? I think not really. Over time, all my codes do end
up like that, until I have time to refactor (put common factors into reusable chunks).
Just don't get disheartened. Some of us here start off with huge refactoring projects, and get
really tired quickly. Whatever codes work for you, use them. I find making a refactoring TODO list
more cost-effective than actually doing the refactoring. I get to meet my deadlines, while still
clearly documenting potential problems so I catch bugs easier if they occur.
As my bosses always say: "Get the job done, now!" :)
Jonathon
Anne wrote:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi Jon
Thanks for the tips.
If I can, I'd like to make the changes general enough that at least
some of them can be incorporated into the main code base.
You are working full-time for a company? :)
Yes. My company. :-) Though I'm not the only employee.
I don't have that luxury. I
just build the codes needed by my clients, and leave it at that.
Massaging those codes to fit into OFBiz will cost me too much. Many
parts in OFBiz are not neatly structured enough (need further
refactoring) to plug in enhancements. That particular Java file you
mentioned is one of them.
In many areas this is what I also will be doing, because I just can't
justify the time to make the functionality general. However I figure
that if a change I make can be incorporated into the main code base,
then I'll benefit as upgrading will be easier. Also, if something I
write has a bug (heaven forbid!) that someone else finds and fixes, or
if the functionality is extended further by someone else, I benefit from
that too. So it is worth me making some effort to make my code good
enough to be integrated.
Some parts of OFBiz are truly truly neat, though.
Yes, I'm noticing. OFBiz is a great system. I'm impressed with the
careful design and amount of thought that has obviously gone into it. It
has its warts, but what software doesn't? At least, being open source, I
can do something about the warts.
Cheers,
Anne.
- --
Coherent Software Australia Pty Ltd
PO Box 2773
Cheltenham Vic 3192
Phone: (03) 9585 6788
Fax: (03) 9585 1086
Web: http://www.cohsoft.com.au/
Email: [EMAIL PROTECTED]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFICsVPtgv4pchABrERAiHWAKCYco66lMYUcUNDg/ag5GhAfKnrNgCgjhkM
w6Sbh29ycr/wAy2gFh4HdvU=
=TuON
-----END PGP SIGNATURE-----
