Yes, I brought it up on the myfaces dev list, but didn't get any comments. I guess I'll open a JIRA issue and take a look at it the next time I have the code checked out. I don't think we have any instances of a new tag handler but not a new component subclass.
Yes, the tenative plan is that Tomahawk2 might be based on Trinidad. First Trinidad needs to graduate and then hopefully we'll accept it as a MyFaces subproject and go from there. Nothing is definite at this point, but there's at least a couple of us that want to see this happen. On 3/27/07, Gary VanMatre <[EMAIL PROTECTED]> wrote:
>From: "Mike Kienenberger" <[EMAIL PROTECTED]> > > Gary, I see this as a tomahawk bug. I'm pretty sure I looked at this > a couple weeks ago and noticed that the renderer was being set inside > the JSP tag handler rather than in the component. Seems like setting > it from the taghandler is the wrong approach. Breaks anything other > than the jsp viewhandler. > Cool. I thought it was too but I understand the reuse that tomahawk has with core. I can see why you wouldn't want to subclass a component just for the sake of changing the rendererType - more code to maintain. On the flip side, it wouldn't be right to override the RI's renderer-class using the same renderer-type and family. Only JSP is mandated by the specification. So, there is a gray area here (calling it a bug). Are you guys planning on using the Trinidad code generation for tomahawk it the future? > > On 3/27/07, Gary VanMatre wrote: > > This looks like another case where we need to explicitly override the > rendererType. > > The shared renderer [1] is the default for the runtime but in tomahawk, there > is a renderer > > override [2]. > > > > > > [1] > http://svn.apache.org/viewvc/myfaces/shared/branches/2_0_0/core/src/main/java/or > g/apache/myfaces/shared/renderkit/html/HtmlCheckboxRendererBase.java?view=markup > > [2] > http://svn.apache.org/viewvc/myfaces/tomahawk/branches/1_1_3/core/src/main/java/ > org/apache/myfaces/renderkit/html/ext/HtmlCheckboxRenderer.java?view=markup
