On 12/14/11 09:37 AM, Alan Coopersmith wrote:
On 12/14/11 09:23, Rich Burridge wrote:
Hi,
Could I please get a code review for my fix for:
6881496 libnet is not Sun Studio compatible
http://monaco.us.oracle.com/detail.jsf?cr=6881496
Webrev is at:
http://jurassic.us.oracle.com/~richb/6881496-v1/
x86 workspace (with just libnet built) is at:
/net/stard.us.oracle.com/tank/ws/UL/6881496/
LGTM for fixing our gate
Okay.
- do you know if anyone's tried getting a fix upstream?
I know of no such effort, but I'm happy to do that. Their project website
( http://www.packetfactory.net/libnet/ ) is giving my a glorious McAfee
"Could Not Connect To Server" error at the moment, so I'll just send
email to the author's email address in the libnet README file.
(The upstream fix should be replacing the gcc-only __sun__ && __svr4__ with the
__sun & __svr4 that both Studio & gcc support, or even better, getting them to
adopt the POSIX style names instead of the less portable BSD style names.)
I'll make sure to include your suggestions.
Thanks.
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
