On 12/14/11 09:59 AM, Danek Duvall wrote:
Rich Burridge wrote:
http://jurassic.us.oracle.com/~richb/6881496-v1/
I'd love to know who put that #if in there in the first place; I don't know
how it ever would have worked. First, __sun__ isn't autodefined, but __sun
is, and __svr4__ isn't, but __SVR4 is, and only on SPARC.
That said, I think (I'm still looking), that this should be protected like
this:
#ifndef __BIT_TYPES_DEFINED__
#define __BIT_TYPES_DEFINED__
typedef ...
#endif
Apparently, several other components do this, and we ship some header files
that do this (see db.h and net/ppp_defs.h for examples), and it's probably
wise to be compatible.
Okay. I'll rework the webrev. Also, rather than open up a new bug
to update the project URL, I'll add that into this one as well.
I'd also ping Roger and Lee to see if they have any opinions on this
particular fix, as well as a long-term solution built-in to the Solaris
header files.
I've bcc:'ed them on this reply.
Roger/Lee, could you please look at the email thread starting at:
http://mail.opensolaris.org/pipermail/userland-discuss/2011-December/002994.html
and send me your comments (either privately or via this list if
you are okay with that).
Thanks.
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
