On 12/14/11 09:37, Alan Coopersmith wrote:
On 12/14/11 09:23, Rich Burridge wrote:
Hi,
Could I please get a code review for my fix for:
6881496 libnet is not Sun Studio compatible
http://monaco.us.oracle.com/detail.jsf?cr=6881496
Webrev is at:
http://jurassic.us.oracle.com/~richb/6881496-v1/
x86 workspace (with just libnet built) is at:
/net/stard.us.oracle.com/tank/ws/UL/6881496/
LGTM for fixing our gate - do you know if anyone's tried getting a fix
upstream?
(The upstream fix should be replacing the gcc-only __sun__ && __svr4__
with the
__sun & __svr4 that both Studio & gcc support, or even better, getting
them to
adopt the POSIX style names instead of the less portable BSD style names.)
Of course, the real fix would be for them to just use the standard c99
data types instead of the gcc-only ones.
-Shawn
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
