On 02/10/2012 12:13 PM, Srinivasa Sarva wrote:
Please review the changes (simple) for
CR7144665 Upgrade pv to 1.2.0

Webrev
http://jurassic.us.oracle.com/net/ssarva-us/export/home/srini/test/Feb10/webrev/index.html

You forgot to update the Copyright in the Makefile.

Why does the Makefile have:

test:           $(NO_TESTS)

?

Both the existing version and the new one you are planning to
update to have a set of tests that could be run.

_______________________________________________
userland-discuss mailing list
userland-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/userland-discuss

Reply via email to