On 02/14/2012 03:31 PM, Srinivasa Sarva wrote:
Issue is "tr -dc" option is behaving differently in solaris version.
If I use this option with gnu version tr
I see the test passing. I filed a bug CR7145628.
Cool. Looking at libneon/Makefile, there's:
COMPONENT_TEST_ENV += PATH="$(GNUBIN):$(PATH)"
A similar line in pv/Makefile seems to work just fine. I suggest
that this is the simplest solution for fixing test #12.
On 02/10/12 17:19, Rich Burridge wrote:
On 02/10/2012 03:59 PM, Srinivasa Sarva wrote:
Rich,
Thanks for the review.
Comments below.
On 02/10/12 14:26, Rich Burridge wrote:
On 02/10/2012 12:13 PM, Srinivasa Sarva wrote:
Please review the changes (simple) for
CR7144665 Upgrade pv to 1.2.0
Webrev
http://jurassic.us.oracle.com/net/ssarva-us/export/home/srini/test/Feb10/webrev/index.html
You forgot to update the Copyright in the Makefile.
Done...
Why does the Makefile have:
test: $(NO_TESTS)
?
Both the existing version and the new one you are planning to
update to have a set of tests that could be run.
My mistake. Updated the Makefile.
I didn't do the existing version and followed the same for new
version.
I'll double check from now.
Webrev
http://jurassic.us.oracle.com/net/ssarva-us/export/home/srini/test/Feb10/webrev/index.html
I tried your changes, and when I run "gmake test" I get:
...
000-cat: OK
001-interval: OK
002-rate: OK
003-progress: OK
004-timer: OK
005-eta: OK
006-ratecount: OK
007-bytes: OK
008-numeric: OK
009-quiet: OK
010-pipe: OK
011-cksum: OK
012-averagerate: FAILED
...
Did you see the same failure?
I played around with 012-averagerate. It looks like the Solaris
version of
tr is causing NUM=1, which fails the test. If I adjust each
occurrence of tr
in that script to /usr/gnu/bin/tr then NUM=0 and the test passes.
I suggest finding out exactly what's going on here, and fix it
accordingly.
If you need to file a bug against one of the Solaris utilities then
please do so.
_______________________________________________
userland-discuss mailing list
userland-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
