I would appreciate a code review:
http://jurassic.us.oracle.com/net/mogo/builds3/cmohrman/userland_php-7177478/webrev/
Don't be offended, yet, by the static version numbers
all over the place.
Since the publish happens at the top level of my directory I don't
have access to the COMPONENT_VERSION numbers.
I should find a way of fixing that someday but now now.
Could a CR be filed to address this please?
I have a couple of comments
1) The various require dependencies of the form
# need generic dependency on PHP itself
depend fmri=web/[email protected] type=require
shouldn't be versioned.
2) In the man page diffs (components/php-common/php.1.sunman), the name
of the Solaris release is incorrect. Since the man page ships in the
product, I would just have this as
Solaris ships with PHP 5.2.17 and 5.3.14.
although even that might be too much.
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
