RE: Cache-Control: no-cache

[Charles Kim]

https://jira.codehaus.org/browse/MRM-1644
Thanks!

-----Original Message-----
From: Brett Porter [mailto:br...@porterclan.net] On Behalf Of Brett Porter
Sent: Friday, July 20, 2012 10:09 AM
To: users@archiva.apache.org
Subject: Re: Cache-Control: no-cache

Thanks - would you mind submitting that as a patch to JIRA 
(http://jira.codehaus.org/browse/MRM)?

Regards,
Brett

On 19/07/2012, at 3:11 PM, Charles Kim wrote:

> But looks like there might be an issue with how header is added. This should 
> use setHeader instead of an addHeader to protect against adding duplicate 
> headers.
> 
>  private void setHeaders( DavServletResponse response, DavResourceLocator 
> locator, DavResource resource )
>    {
>        // [MRM-503] - Metadata file need Pragma:no-cache response
>        // header.
>        if ( locator.getResourcePath().endsWith( "/maven-metadata.xml" ) )
>        {
>            response.addHeader( "Pragma", "no-cache" );
>            response.addHeader( "Cache-Control", "no-cache" );
>        }
> 
>        // We need to specify this so connecting wagons can work correctly
>        response.addDateHeader( "last-modified", 
> resource.getModificationTime() );
> 
>        // TODO: [MRM-524] determine http caching options for other types of 
> files (artifacts, sha1, md5, snapshots)
>    }
> 
> < HTTP/1.1 200 OK
> < Cache-Control: public, max-age=600, s-maxage=600 < Pragma: no-cache 
> < Cache-Control: no-cache < Last-Modified: Thu, 19 Jul 2012 22:09:53 
> GMT < Content-Length: 3376 < Vary: Accept-Encoding < Connection: close 
> < Content-Type: application/xml;charset=UTF-8
> 
> -----Original Message-----
> From: Charles Kim [mailto:charl...@yahoo-inc.com]
> Sent: Thursday, July 19, 2012 3:02 PM
> To: users@archiva.apache.org
> Subject: RE: Cache-Control: no-cache
> 
> Nm. I found that no-cache is added for maven-metadata.xml files.
> 
> -----Original Message-----
> From: Charles Kim [mailto:charl...@yahoo-inc.com]
> Sent: Thursday, July 19, 2012 2:21 PM
> To: users@archiva.apache.org
> Subject: Cache-Control: no-cache
> 
> Does Archiva add any cache control response headers by default? I doubt that 
> this is done by Archiva and most likely done by tomcat but just wanted to 
> make sure.  Tried setting the disableProxyCaching to false but didn't seem to 
> remove this header.
> Thanks