Hi, --- On Sun, Oct 4, 2009 at 1:59 AM, Ratnadeep Debnath <[email protected]> wrote: | I have moved the old repository to | http://gitorious.org/~rtnpro/fedx/rtnpros-clone-bak. \--
Give a meaningful name! Since it is grsync code, you could have called it as rtnpros-clone-grsync-backup. --- | I have started with a fresh clone from the mainline at | http://gitorious.org/~rtnpro/fedx/rtnpros-fedx-clone \-- Not bad for a start :) On commit 1fe6982... * If you create a src/ directory, then you should have a top-level Makefile. There is only one Makefile required for this project at the moment. So you can put it in the top-level directory. You don't need src/. Just have the README and the Makefile. * You don't need to set SHELL = /bin/bash. * When you set global variables in Makefile, use capital letters. "distro = fedora" should be "DISTRO=fedora", for example. Don't give space on either side of the assignment statement. * Don't ship vsftp rpm in these sources. Only one Makefile and README file should be there in your code-base. We cannot ship vsftpd for each and every RPM-based distro. You will need a global variable that sets the path of the external disk, and then we should use this path to install vsftpd from the external disk. * Why are you giving a space between a target and colon (:)? Please go through some existing Makefile examples. * You have put all the directories under a single dirs variable. What if the user doesn't want rpmfusion repositories? You have to create separate global variables for each entry, and put them all as dependencies for a target. For example: === SNIPPET === all: releases updates rpmfusion releases: <Fill here> updates: <Fill here> rpmfusion: <Fill here> === END === You can even add dependencies in rpmfusion target just like 'all' target. * Did you actually test the Makefile? There is a spelling mistake: rpmfusion/nonfree/$(dsitro)/ Please update the required changes. Do some testing as well. SK -- Shakthi Kannan http://www.shakthimaan.com _______________________________________________ Users mailing list [email protected] http://lists.dgplug.org/listinfo.cgi/users-dgplug.org
