Hi, ---On Sun, Oct 4, 2009 at 10:06 AM, Shakthi Kannan <[email protected]> wrote:--- > * When you set global variables in Makefile, use capital letters. > "distro = fedora" should be "DISTRO=fedora", for example. Don't give > space on either side of the assignment statement. > > * Don't ship vsftp rpm in these sources. Only one Makefile and README > file should be there in your code-base. We cannot ship vsftpd for each > and every RPM-based distro. You will need a global variable that sets > the path of the external disk, and then we should use this path to > install vsftpd from the external disk.
I have made the mentioned changes. Added a global variable path to the external disk. If vsftpd is not found in the system, then make will install vsftpd from the repo in the external disk. > * You have put all the directories under a single dirs variable. What > if the user doesn't want rpmfusion repositories? You have to create > separate global variables for each entry, and put them all as > dependencies for a target. > You can even add dependencies in rpmfusion target just like 'all' target.. Done and tested successfully > * Did you actually test the Makefile? There is a spelling mistake: > > rpmfusion/nonfree/$(dsitro)/ > Sorry for the type error. Actually I checked whether make was then working or not, but didn't continue till this part. That's why I couldn't detect the error. I will take care in this matter from now on. > Please update the required changes. Do some testing as well. Just now I have pushed a commit to gitorious. I couldn't do that yesterday due to network disturbances. Thanks, Regards, rtnpro _______________________________________________ Users mailing list [email protected] http://lists.dgplug.org/listinfo.cgi/users-dgplug.org
