Hi, --- On Mon, Oct 5, 2009 at 12:01 PM, Ratnadeep Debnath <[email protected]> wrote: | I have made the mentioned changes. \--
... and before you send an e-mail, review the requested changes once, so you haven't missed out on any. There is still a space on either side of the "=" assignment. On commit ff62ed9 ... * You will need to learn to abstract things as much as possible. Split DIR_RPMFUSION into multiple global variables, and put each one as a separate target. * Add rsync as a global variable, instead of hard-coding the same in the rules. RSYNC=rsync * zer0cool had a useful suggestion on 'rpm -q vsftp', which is faster. Use it. * You don't need to put all the targets as dependencies in "all". Use logic here. 'releases', 'updates', 'rpmfusion' all depend on 'check_vsftpd'. So, just putting these three in 'all' will make sure that check_vsftpd is invoked. You will need to work on the dependencies, so you don't have redundant dependency checks. --- | If vsftpd is not found in the system, then make will install vsftpd | from the repo in | the external disk. \-- * Why hard-code the vsftpd version number? It need not necessarily be 2.1.2.-1 Fedora 11 version. You need to think about future versions too. Just use something like vsftpd*. @zer0c00l: We define our workflows. If there is a Makefile in the master repository, then I can merge your request. Since, Makefile is not in the master repository, I cannot merge your request. You could: (a) send a patch to rtnpro, or (b) clone rtnpros' repo, merge it to yours, do the changes, and ask rtnpro to merge it back. SK -- Shakthi Kannan http://www.shakthimaan.com _______________________________________________ Users mailing list [email protected] http://lists.dgplug.org/listinfo.cgi/users-dgplug.org
