Andrew, there was no intention to involve any Trinidad team activity for this. Sorry for any misinterpretation.
I wrote "adapted to Trinidad" not "adapted by the Trinidad team".
I guess that - since the hacking was done by some MyFaces team - they will be eventually pleased to adapt such hack to Trinidad.
Regards,

-- Renzo

Andrew Robinson wrote:


On Fri, Feb 15, 2008 at 1:40 AM, Renzo Tomaselli <[EMAIL PROTECTED]> wrote:
Matthias,
    AFAIK jsCookMenu is a third party component adapted by Tomahawk to JSF which in turn should be adapted to Trinidad.

-1

There is no *should*. If someone wants to write a jsCookMenu for trinidad, they are welcome to, but it is not the responsibility of the Trinidad team to make 3rd party JS libraries work.
 

By "file a bug against the cookMenu" I guess you mean the Tomahawk team, since they provide the patch which should be patched.
Also I guess that many symbols around should prove that Trinidad is in the game.
Wouldn't be just as easy as "if (submitForm) ..." ?

-- Renzo


Matthias Wessendorf wrote:
Hi,

On Thu, Feb 14, 2008 at 1:36 PM, Renzo Tomaselli
<[EMAIL PROTECTED]> wrote:
  
 Ok, here is a solution.
 Myfaces adds a MyFacesHack.js to the page for the purpose of adapting
jscookMenu to JSF.
 Here a menu action goes straightaway to form.submit. This doesn't comply
with tr:fileDownloadActionListener, don't know why.
 But replacing at line #28:

             var dummyForm = document.forms[target];
             dummyForm.elements['jscook_action'].value = link;
             dummyForm.submit();

 simply by:

             submitForm(target,1, {jscook_action: link})

 seems to solve the issue, since we go through Trinidad stuff.
 However I don't know how Myfaces+Trinidad+Tomahawk fit this puzzle (who
does what).
    
the big problem here is that two different (JS) libs are used. There
is no unique way
to handle these different (ajax/js) lib. OpenAjax provides a hub for this..

We could "hack" the Tomahawk renderer for the jsCookMenu to go through Trinidad,
when Trinidad RenderKit is used.

Do you mind to file a bug against the cookMenu ?

-M
  
 -- Renzo




 Renzo Tomaselli wrote:
 Yes I will. I'm debugging the involved js machinery to find the issue, I
guess jscookMenu submitting skips Trinidad internals.

 -- Renzo

 Matthias Wessendorf wrote:
 can you create an issue + a little simple page snippet ?

-M

On Thu, Feb 14, 2008 at 12:34 PM, Renzo Tomaselli
<[EMAIL PROTECTED]> wrote:


 Hi, I have another issue with tr:fileDownloadActionListener.
 I'm using Tomahawk jscookMenu since Trinidad misses any drop-down menu
 component.
 After performing a download action (even canceled), I noticed that any
 following jscookMenu item action leads to the download action again and
 again,
 until next page refresh.

 -- Renzo








    
  

Reply via email to