On Wed, 2019-05-08 at 10:41 -0400, Andrew Stitcher wrote: > On Wed, 2019-05-08 at 13:29 +0100, Gordon Sim wrote: > > ... > > * ran all python examples (against qpid-cpp broker for those that > > require a broker) > > - the helloworld_direct_tornado.py no longer works (it does work > > with > > 0.27.1) > > Not sure whether this is deliberate or expected. > > It is expected to work. It certainly was working when the python > changes were initially committed. I will give this a try and see > what's > going on.
The work to fix the reconnect behaviour (and reinstate non blocking connect) did indeed break the tornado examples. I would make this release blocking except that the tornado examples were actually broken for a long time (afaict) before I fixed them in SHA 603ce7a7 (PROTON-1991) which was only 4 months ago so I'm not actually sure how many people really care about them. On the other hand it is a regression from 0.27, but not exactly a regression for some earlier releases (but with different problems). Gordon do you want to make this failure -1 the release and respin when I have a fix? Andrew --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
