On Wed, 2019-05-08 at 21:25 -0400, Andrew Stitcher wrote: > ... > > Whats the nature of the issue/fix? Is it only these examples that > > would > > be affected? > > I'll know when I find the fix! It's not entirely clear yet - but it > looks like the existing code might only accidentally work.
Phew - the existing code is correct, but the reconnect work has changed the implicit protocol between proton and the select implementation (usually internal to the proton binding, but wth an external loop like tornado the external loop). To fix this and maintain the capability of external loops isn't trivial - at least a days work. This change supports an important change (and IMO fix) to the python bindings of correctly trying *all* the addresses/IP protocols associated with a given DNS name that I think is more important than the external loop abiility. This being so - I'd recommend releasing this as is with a release note and being sure to fix this issue for 0.29. Andrew --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
