On Wed, 2019-05-08 at 23:23 +0100, Gordon Sim wrote: > ... > > On the other hand it is a regression from 0.27, but not exactly a > > regression for some earlier releases (but with different problems). > > I've gone back through 0.27.1, 0.26.0, 0.25.0, 0.24.0 and 0.23.0 and > in > all those helloworld_tornado.py and helloworld_direct_tornado.py > work > though you are right that the recurring_timer_tornado.py example did > not.
Indeed, the issue was with the tornado scheduler example - I expect that made me think those examples were unmaintained and nobody really cared about them - why not run that test too? > > Gordon do you want to make this failure -1 the release and respin > > when > > I have a fix? > > Whats the nature of the issue/fix? Is it only these examples that > would > be affected? I'll know when I find the fix! It's not entirely clear yet - but it looks like the existing code might only accidentally work. > > My inclination would be to respin with the fix. Though I would > readily > concede that the examples are corner cases, I believe they have been > working through recent releases (apart from the timer one) and it > would > be a shame to break that without some reason. Agreed. Andrew --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
