+1

* Validated checksum
* Built from source on Raspberry PI 4 (Raspbian Buster, 32bit and Ubuntu
20.04, 64 bit) with gcc and clang, and ran the test suite
* Ran python tox test on that Ubuntu

Notes:

# Got compilation failure with clang-10 on Ubuntu; it compiled fine with
clang-9 and gcc

[ 23%] Building C object c/examples/CMakeFiles/c-send-ssl.dir/send-ssl.c.o
cd /home/ubuntu/repos/qpid-proton-0.31.0/clangrelease/c/examples &&
/usr/bin/clang-10  -I/home/ubuntu/repos/qpid-proton-0.31.0/c/include
-I/home/ubuntu/repos/qpid-proton-0.31.0/c/src
-I/home/ubuntu/repos/qpid-proton-0.31.0/clangrelease/c
/include -I/home/ubuntu/repos/qpid-proton-0.31.0/clangrelease/c/src  -O2 -g
-DNDEBUG   -Werror -Wall -pedantic -std=iso9899:1990 -pedantic -o
CMakeFiles/c-send-ssl.dir/send-ssl.c.o   -c
/home/ubuntu/repos/qpid-proton-0.31.0/c/examples/send-ssl.c
In file included from
/home/ubuntu/repos/qpid-proton-0.31.0/c/examples/send-ssl.c:22:
In file included from
/home/ubuntu/repos/qpid-proton-0.31.0/c/include/proton/connection.h:26:
In file included from
/home/ubuntu/repos/qpid-proton-0.31.0/c/include/proton/codec.h:26:
/home/ubuntu/repos/qpid-proton-0.31.0/c/include/proton/object.h:206:11:
error: '_Bool' is a C99 extension [-Werror,-Wc99-extensions]
PN_EXTERN bool pn_class_equals(const pn_class_t *clazz, void *a, void *b);
/usr/lib/llvm-10/lib/clang/10.0.0/include/stdbool.h:15:14: note: expanded
from macro 'bool'


#define bool _Bool

# Got a failing Go test on Raspbian. It looks to be affecting only 32bit
systems. It was not fixed for me by
https://github.com/apache/qpid-proton/pull/233

$ go version
go version go1.11.6 linux/arm

 --- FAIL: TestPrimitivesCompatible (0.00s)
    interop_test.go:66: Decode failed cannot unmarshal AMQP ulong to Go uint
    interop_test.go:66: Decode failed cannot unmarshal AMQP ulong to Go int
    interop_test.go:66: Decode failed cannot unmarshal AMQP ulong to Go
float64
    interop_test.go:66: Decode failed cannot unmarshal AMQP ulong to Go
float64

# On Ubuntu, tox test which was reported as testing with python 2.6 was
apparently using python 3.8; I investigated because I don't have python 2.6
installed in the system, wanted to know how tox got to it; it actually did
not!

python/.tox$ ls */bin/python*
py26/bin/python  py26/bin/python3  py26/bin/python3.8  py27/bin/python
 py27/bin/python2  py27/bin/python2.7  py38/bin/python  py38/bin/python3
 py38/bin/python3.8

# Additional warning from swig wrapper, in Ruby, with swig 4.0.1; there is
a ton of warnings from the wrappers, especially when compiling the Python
wheel

[ 99%] Building C object
ruby/CMakeFiles/cproton-ruby.dir/cprotonRUBY_wrap.c.o
In file included from /usr/include/string.h:495,
                 from
/home/ubuntu/repos/qpid-proton-0.31.0/gcc/ruby/cprotonRUBY_wrap.c:441:
In function ‘strncpy’,
    inlined from ‘Pn_rbkey_set_key_value’ at
/home/ubuntu/repos/qpid-proton-0.31.0/gcc/ruby/cprotonRUBY_wrap.c:2431:3:
/usr/include/aarch64-linux-gnu/bits/string_fortified.h:106:10: warning:
‘__builtin_strncpy’ specified bound depends on the length of the source
argument [-Wstringop-overflow=]
  106 |   return __builtin___strncpy_chk (__dest, __src, __len, __bos
(__dest));
      |
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/ubuntu/repos/qpid-proton-0.31.0/gcc/ruby/cprotonRUBY_wrap.c: In
function ‘Pn_rbkey_set_key_value’:
/home/ubuntu/repos/qpid-proton-0.31.0/gcc/ruby/cprotonRUBY_wrap.c:2431:40:
note: length computed here
 2431 |   strncpy(rbkey->key_value, key_value, strlen(key_value) + 1);
      |                                        ^~~~~~~~~~~~~~~~~

# Got a warning when compiling with GCC 8.3.0 on Raspbian (no such warning
with clang-9 there, or with GCC in Ubuntu)

Scanning dependencies of target py_pkg_wheel
running bdist_wheel
running build
running build_py
running build_ext
running configure
Did not find libqpid-proton-core via pkg-config:
Building the bundled proton-c sources into the extension
Using openssl version 1.1.1d (found via pkg-config)
creating build
creating build/temp.linux-armv7l-2.7
creating build/temp.linux-armv7l-2.7/tmp
cc -c /tmp/sasl_client_doneEcGiwW.c -o
build/temp.linux-armv7l-2.7/tmp/sasl_client_doneEcGiwW.o
/tmp/sasl_client_doneEcGiwW.c:2:1: warning: return type defaults to ‘int’
[-Wimplicit-int]
 main (int argc, char **argv) {
 ^~~~
--
Mit freundlichen Grüßen / Kind regards
Jiri Daněk

Reply via email to