>>Thanks for your suggestion on adding tests. I'll work on those. I have added a few integration tests to validate the behavior. I am using 'Sling Testing Tools' as specified at [0]. The integration tests are run via HTTP requests against a Sling test instance that is started during the Maven build cycle, This blog at [1] was really helpful in getting things setup for writing the integration tests.
Also the tests use local DynamoDB instance (see [2]) which is basically a local DynamoDB setup with the same api support as the real dynamodb on AWS. This prevents the tests from incurring api usage costs on AWS. Again I was lucky to find a very useful resource for integrating local dynamodb with maven build cycle here at [3] [0] - http://sling.apache.org/documentation/development/sling-testing-tools.html [1] - http://labs.sixdimensions.com/blog/2013-06-05/creating-integration-tests-apache-sling/ [2] - http://docs.aws.amazon.com/amazondynamodb/latest/developerguide/Tools.DynamoDBLocal.html [3] - http://dynamodb.jcabi.com/ Thanks On Wed, Jan 21, 2015 at 4:05 PM, connuser1 connuser1 <[email protected]> wrote: > Thanks Dominic and Bertrand for your valuable comments. This > implementation is an offshoot of the work that I am doing currently in my > job and my intent is to share any generic part which could help others. I > am quite enthusiastic about maintaining and improving it as I would have to > do it anyway for my project work. > > Thanks for your suggestion on adding tests. I'll work on those. > > Thanks > > On Wed, Jan 21, 2015 at 3:12 PM, Bertrand Delacretaz < > [email protected]> wrote: > >> Hi, >> >> On Wed, Jan 21, 2015 at 10:24 AM, Dominik Süß <[email protected]> >> wrote: >> > ...I think this could be a great contribution to Sling as it opens new >> options >> > and could make Sling attractive to people yet not having checked out the >> > power of Sling yet - but there needs some commitment to maintain it over >> > the long run or it will orphan over a while and soon be outdated.... >> >> People can not always commit to maintain something for the "long run" >> - as far as the Sling /contrib modules are concerned, I'd say if >> someone's planning to reasonably maintain something for a year that's >> good enough. We don't have any maintenance expectations for /contrib >> stuff anyway. that's best effort. >> >> One thing that helps a lot IMO is strong test coverage, to allow >> others who might pick up the work to check that it works as expected >> before starting to hack on it. >> >> -Bertrand >> > >
