yes. that is why our validation is more then just validators validate() { validateRequired(); convertInput(); validateValidators(); }
this also has the advantage that type conversion is only performed once -igor On Dec 4, 2007 7:46 PM, rkanadam <[EMAIL PROTECTED]> wrote: > > Igor Vaynberg wrote: > > why do you think the validator should be called first? if you attach a > > Number.maximum(5) validator to a textfield do you think the validator > > should work on input string("5") or should string("5") firsrt be > > converted to int(5) and validator should work with that? > > > > imho it was pretty wrong in 1.2 and we have fixed it in 1.3 > > > > -igor > > > > > > On Dec 4, 2007 6:32 PM, JulianS <[EMAIL PROTECTED]> wrote: > > > >> We are migrating our app from 1.2.6 to 1.3-rc1 and we have certain form > >> fields that have both a converter and a validator attached to them. In > >> 1.2.6, the validator was called first, as it should be; in 1.3 it's the > >> other way around and it's therefore broken. The only changes we've made are > >> as per the migration guide. Is this a bug or is there something else we > >> need > >> to change? > >> > >> Thanks, > >> Julian > >> > >> -- > >> View this message in context: > >> http://www.nabble.com/Problem-with-1.3-Validation-and-Conversion-order-tf4947088.html#a14164082 > >> Sent from the Wicket - User mailing list archive at Nabble.com. > >> > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: [EMAIL PROTECTED] > >> For additional commands, e-mail: [EMAIL PROTECTED] > >> > >> > >> > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > Isn't that a tricky reply, successful conversion is a form of > validation, what if the conversion fails ... ? > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]