Wouldn't it be better to leave the generic part to this reusable link
then? Why 'pollute' all links with a generic parameter?
Back to your definition:
(1) only components that use their model have a generic type
(components you are likely to call getmodel/getmodelobject on as a
user).
What now? Components that use their model *or* you're likely to call getmodel
on? Seems to me as two different things:
Link doesn't fit in the first category nor is it always used with a model.
Sven
Igor Vaynberg schrieb:
if your link is anonymous, yes. if you have reusable links in their
own class, then no.
-igor
On Tue, Jul 1, 2008 at 12:24 PM, Joni Freeman <[EMAIL PROTECTED]> wrote:
Isn't this a same thing:
onPopulateItem(final Item<User> item) {
add(new Link("delete") {
protected void onClick() { service.delete(item.getModelObject()); }
});
}
Joni
On Tue, 2008-07-01 at 11:56 -0700, Igor Vaynberg wrote:
onPopulateItem(Item<User> item) {
add(new Link<User>("delete", item.getModel()) {
protected void onClick() { service.delete(getModelObject()); }
});
}
-igor
On Tue, Jul 1, 2008 at 11:51 AM, Rodolfo Hansen <[EMAIL PROTECTED]> wrote:
I too like this compromise alot
Although I don't see a good use case for generifying Link ?
Am I missing something?
On Fri, Jun 27, 2008 at 2:49 PM, Timo Rantalaiho <[EMAIL PROTECTED]>
wrote:
On Fri, 27 Jun 2008, Igor Vaynberg wrote:
since no one complained, should we apply this change over the weekend?
and soon thereafter release m3?
I prefer this over M2. Even though:
user). so far these are link,form,formcomponent
Link might be better without the type parameter. It's no big
deal though.
And yes, it would be good if for example Johan and Gerolf
who have invested a lot of effort on the generification
could have a closer look and tell what they think before
proceeding.
Best wishes,
Timo
--
Timo Rantalaiho
Reaktor Innovations Oy <URL: http://www.ri.fi/ >
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
