LGTM
http://codereview.chromium.org/12427/diff/1/46 File src/assembler-ia32.cc (right): http://codereview.chromium.org/12427/diff/1/46#newcode431 Line 431: int pos = label->pos() + Code::kHeaderSize; Known bug: Off-by-one. Must subtract kHeapObjectTag as well, so result becomes relative to actual Code* value. (I'll fix it post-merge) http://codereview.chromium.org/12427/diff/1/46#newcode872 Line 872: void Assembler::rep_cmpsb() { Should this be split into cld, rep and cmpsb? The combination seems to belong in macro_assembler, not plain assembler. http://codereview.chromium.org/12427/diff/1/46#newcode1340 Line 1340: long_at_put(fixup_pos, pos + Code::kHeaderSize); Off-by-one here too. http://codereview.chromium.org/12427 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
