I'm afraid I don't like parts of this change. The new RegExpMacroAssemblerImpl typedef is only used in one place and that's inside an ifdef. It only adds confusion. The new include file does something very simple and is used twice where it could be inlined.
Modulo this and the other comments it LGTM http://codereview.chromium.org/12427 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
