Oops, this comment should have been attached to http://codereview.chromium.org/12469
On Wed, Nov 26, 2008 at 1:33 PM, <[EMAIL PROTECTED]> wrote: > I'm afraid I don't like parts of this change. The new > RegExpMacroAssemblerImpl typedef is only used in one place and that's > inside an ifdef. It only adds confusion. The new include file does > something very simple and is used twice where it could be inlined. > > Modulo this and the other comments it LGTM > > > http://codereview.chromium.org/12427 > -- Erik Corry, Software Engineer Google Denmark ApS. CVR nr. 28 86 69 84 c/o Philip & Partners, 7 Vognmagergade, P.O. Box 2227, DK-1018 Copenhagen K, Denmark. --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
