LGTM.
http://codereview.chromium.org/155211/diff/20/1016 File src/heap.cc (right): http://codereview.chromium.org/155211/diff/20/1016#newcode3129 Line 3129: // Try to shrink global property cell, map, old, and code spaces. Maybe just cell, map ... http://codereview.chromium.org/155211/diff/20/1016#newcode3130 Line 3130: cell_space_->Shrink(); If the order isn't important here, maybe we should look into doing it in the same order everywhere? Not a big deal. http://codereview.chromium.org/155211/diff/20/1024 File src/mark-compact.cc (right): http://codereview.chromium.org/155211/diff/20/1024#newcode1753 Line 1753: Two newlines here? http://codereview.chromium.org/155211/diff/20/1017 File src/serialize.h (right): http://codereview.chromium.org/155211/diff/20/1017#newcode324 Line 324: List<Page*> cell_pages_; // All pages in the global property cell space. the cell space. http://codereview.chromium.org/155211/diff/20/1022 File src/spaces.cc (right): http://codereview.chromium.org/155211/diff/20/1022#newcode1460 Line 1460: Reset(); Weird indentation. http://codereview.chromium.org/155211 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
