New changelist uploaded. Take a quick look at the diff.
http://codereview.chromium.org/155211/diff/20/1026 File src/globals.h (right): http://codereview.chromium.org/155211/diff/20/1026#newcode268 Line 268: LAST_SPACE = LO_SPACE // <= 9 (see kSpaceBits and kLOSpacePointer) The extra bits are used for two "pseudo" tags in the serializer. I've changed the serializer to use 4 bits, everywhere else (ie, RetryAfterGC failures) to use 3. Added asserts for both places. http://codereview.chromium.org/155211/diff/20/1016 File src/heap.cc (right): http://codereview.chromium.org/155211/diff/20/1016#newcode850 Line 850: cell_space_->ClearRSet(); I wanted to put the allocation change in first, then change GC to stop reading rset bits, then stop writing them. It's asier to review, and if something goes wrong, easier to diagnose. (On the other hand, it's harder to back out if we have to.) http://codereview.chromium.org/155211/diff/20/1024 File src/mark-compact.cc (right): http://codereview.chromium.org/155211/diff/20/1024#newcode1753 Line 1753: On 2009/07/08 11:31:16, Kasper Lund wrote: > Two newlines here? Done. http://codereview.chromium.org/155211/diff/20/1017 File src/serialize.h (right): http://codereview.chromium.org/155211/diff/20/1017#newcode324 Line 324: List<Page*> cell_pages_; // All pages in the global property cell space. On 2009/07/08 11:31:16, Kasper Lund wrote: > the cell space. Done. http://codereview.chromium.org/155211/diff/20/1022 File src/spaces.cc (right): http://codereview.chromium.org/155211/diff/20/1022#newcode1460 Line 1460: Reset(); On 2009/07/08 11:31:16, Kasper Lund wrote: > Weird indentation. Done. http://codereview.chromium.org/155211 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
