I would eliminate the remember set code for the cell space and add mandatory iterations of global cells before a commit. Otherwise, LGTM, Lars
http://codereview.chromium.org/155211/diff/20/1026 File src/globals.h (right): http://codereview.chromium.org/155211/diff/20/1026#newcode268 Line 268: LAST_SPACE = LO_SPACE // <= 9 (see kSpaceBits and kLOSpacePointer) Please check the extra bit is needed. AND please add an assert checking the LAST_SPACE can be encoded in kSpaceTagSize bits. http://codereview.chromium.org/155211/diff/20/1016 File src/heap.cc (right): http://codereview.chromium.org/155211/diff/20/1016#newcode850 Line 850: cell_space_->ClearRSet(); I'm confused. Why build a remembered set for a space where we are about to ignore it???????? http://codereview.chromium.org/155211/diff/20/1016#newcode2850 Line 2850: space == cell_space_ || Why do we iterate over cell_space_? http://codereview.chromium.org/155211 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
