LGTM!
http://codereview.chromium.org/149542/diff/1045/34 File src/debug.cc (right): http://codereview.chromium.org/149542/diff/1045/34#newcode337 Line 337: // Step in through constructs call requires no changes to the running code. Not your change, but: constructs -> construct http://codereview.chromium.org/149542/diff/1045/34#newcode339 Line 339: // because caller of this function(Debug::PrepareStep) is expected to Add space before '('. http://codereview.chromium.org/149542/diff/1045/34#newcode340 Line 340: // flood top frame's function with one shot breakpoints. top frame's -> the top frame's http://codereview.chromium.org/149542/diff/1045/33 File src/objects.cc (right): http://codereview.chromium.org/149542/diff/1045/33#newcode222 Line 222: // Protect the receiver and getter in handles as the debugger can allocate Comment no longer needed since everything is in handles here already. http://codereview.chromium.org/149542/diff/1045/33#newcode1638 Line 1638: // Protect the receiver and setter in handles as the debugger can allocate Comment no longer needed. http://codereview.chromium.org/149542 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
