Comment #3 on issue 448 by erik.corry: X11 defines True and False http://code.google.com/p/v8/issues/detail?id=448
We don't define True, we declare V8::True(). Here are three ways to handle this: Number 1: #include Xlib.h #undef True #undef False #include "v8.h" #define True 1 // If you really want this. #define False 0 Number 2: #include "v8.h" #include "Xlib.h" Number 3: Have two different C/C++ files. One includes Xlib.h, the other includes v8.h. This is often a good idea anyway for reasons of modularity. I can't see us using the helper header idea. In a C++ header it is better to use namespaces than #defines. Using #defines would disconnect the real names (as seen by the debugger) from those in the source files. #defines also don't respect namespaces, which is the reason for the issues you are seeing with Xlib.h. Introducing lots of new defines as the normal way to work with V8 would cause more of such problems down the line. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
