Comment #4 on issue 448 by mike.emmel: X11 defines True and False http://code.google.com/p/v8/issues/detail?id=448
So in the WebKit source code base I'm going to be able to reliably do this #include <v8.h> #incldue "Xlib.h" #undef True opens up potential runtime problems. The problem is True and False are part of the posix platform your breaking your unix compatibility doing this. Its sad that xlib defined them and its a legacy issue but you have to respect the platforms you reasonably want to support. You would not name anything that clashes with the core Window headers OS or even libc clashing with xlib.h is just as bad. Given that xlib.h is buried deep inside platform widget libraries an V8 bindings are generated by a code generator and the ultimate point at which a clash between v8 and xlib is uncertain and your clashing with a very common platform header I don't think its a xlib problem. I consider this a fairly serious problem that can be remedied now while V8 is still not in widespread use. Or you can let it go and shrug off the complaints if V8 becomes widely deployed. Given I'm almost done integrating V8 into the Gtk WebKit build I'm not thrilled about the implications of your naming decision. I'm about to make a lot of people unhappy as they encounter this issue. I don't have control I'm also a library developer I can't alert everyone planning on using the webkit library about this problem with V8 all I can do is let you know it exists and point out that you would never conflict with the system headers on other platforms and leave it at that. I don't have the options your suggesting and there is nothing I can do about this. Can I hack the header for a build sure and I will but I can't distribute that hacked header so .. Can I track all the variants of includes to catch when v8 comes in to WebKit maybe maybe not I'll give it a try but regardless I'm still forced to push the problem out to application developers. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
