Hi, to be honest, v8 devs are right. They are not redefining anything. True and False are not C/C++ keywords and they are using just symbols - it's legal! This is actually problem of xlib that defines them. Look at Qt, look at Gtkmm, look at other GUI toolkits how xlib is usually included. All these libs needs to redefine Xlib symbols adding them to, for example, Xlib namespace. I really not see problem in V8.
Cheers - Petr 2009/9/25 <[email protected]>: > > > Comment #6 on issue 448 by mike.emmel: X11 defines True and False > http://code.google.com/p/v8/issues/detail?id=448 > > I can't resist its a frickin virus more of this in the Chrome source code. > chromium/third_party/npapi/bindings/npapi.h > > npapi.h a critical header for plugin developers has this beauty in it. > > #if defined(XP_UNIX) > # include <stdio.h> > // BEGIN GOOGLE MODIFICATIONS > #if 0 > // END GOOGLE MODIFICATIONS > # if defined(MOZ_X11) > # include <X11/Xlib.h> > # include <X11/Xutil.h> > # endif > // BEGIN GOOGLE MODIFICATIONS > #endif > // END GOOGLE MODIFICATIONS > #endif > > Are you sure you want to promote clashing with xlib ? > I'm surprised I'm the first to raise this issue. > Ohh well its your problem not mine. > > > -- > You received this message because you are listed in the owner > or CC fields of this issue, or because you starred this issue. > You may adjust your issue notification preferences at: > http://code.google.com/hosting/settings > > > > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
